Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add consistency checks of HISTORY.rc selections #204

Open
gmao-rreichle opened this issue May 1, 2020 · 2 comments · Fixed by #282
Open

add consistency checks of HISTORY.rc selections #204

gmao-rreichle opened this issue May 1, 2020 · 2 comments · Fixed by #282
Assignees
Labels
0-diff consistency check check guarding against user error pre-processing

Comments

@gmao-rreichle
Copy link
Contributor

Add the following consistency checks of HISTORY.rc selections to pre-processing:

  1. Monthly-mean output is generated in post-processing for resource parameter POSTPROC_HIST>0 (formerly MONTHLY_OUTPUT>0). Monthly-mean values are accurate only if ref_time is 000000 in HISTORY.rc. Currently, there is only a comment in GEOSldas_LDAS.rc to this effect.
    Add a consistency check that verifies that for POSTPROC_HIST>0 all ref_time entries are 000000 in HISTORY.rc. Exit script and stop pre-processing if inputs are found to be inconsistent.

  2. Owing to limitations in MAPL, HISTORY output in grid space (2d) does not yet work when running GEOSldas on EASE grid tiles. Currently, there is only a comment in the (fairly outdated) GEOSldas tutorial. Add a consistency check that verifies that output is in tile space (1d) whenever GEOSldas runs on EASE grid tiles. Exit script and stop pre-processing if inputs are found to be inconsistent.

cc: @gmao-jkolassa

@weiyuan-jiang
Copy link
Contributor

  1. one is addressed 2) we will add EASE grid factory the address broader issue

@gmao-rreichle gmao-rreichle linked a pull request Jul 29, 2020 that will close this issue
@gmao-rreichle
Copy link
Contributor Author

Modifications are needed: If monthly output is requested and reftime is not 000000, the desired behavior is to exit. This needs to be checked in lenkf.j before GEOSldas runs.

@gmao-rreichle gmao-rreichle added the consistency check check guarding against user error label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-diff consistency check check guarding against user error pre-processing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants