Submodules, code org strategy and helper procedures

[bena-nasa]

I'm poking around the geom manager in MAPL3, and saw some duplication that seemed odd. I noticed that for example these two files now define the same helper procedure?

https://github.com/GEOS-ESM/MAPL/blob/release/MAPL-v3/geom_mgr/GeomManager/make_geom_spec_from_hconfig.F90#L26
https://github.com/GEOS-ESM/MAPL/blob/release/MAPL-v3/geom_mgr/GeomManager/make_geom_spec_from_metadata.F90#L26

I guess the original single submodule had this helper procedure and after splitting this up now both need it so there's no choice but to re-implmente it in both submodules?

Is this the strategy then if you have helper procedures that are not type-bound, not intended to be public, and don't fit the naming and organization scheme?

[tclune]

Good catch. So long as the interface is in the main module, only one submodule should implement it. I'll take a look.

[tclune]

I think @JulesKouatchou simply missed this when splitting the original module apart.

@JulesKouatchou Please do a PR to fix this. Discuss with me if unsure how to proceed.