Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMask 4.0 failing on S2 scenes with partial coverage #3

Closed
dionhaefner opened this issue Aug 31, 2018 · 8 comments
Closed

FMask 4.0 failing on S2 scenes with partial coverage #3

dionhaefner opened this issue Aug 31, 2018 · 8 comments

Comments

@dionhaefner
Copy link

I noticed that FMask 4.0 standalone fails on some S2 scenes with the error

Cell contents reference from a non-cell array object.

Error in ReadSunViewGeometryMSI (line 171)


Error in nd2toarbt_msi2 (line 44)


Error in LoadData (line 105)


Error in autoFmask (line 96)


Error in Fmask_4_0 (line 10)

MATLAB:cellRefFromNonCell

All of the offending scenes are from orbits only partially covering the tile, like this one:

fmask_fail

List of failing scenes:

S2B_MSIL1C_20180801T104019_N0206_R008_T32UPF_20180801T161339
S2A_MSIL1C_20180727T104021_N0206_R008_T32UPF_20180727T125155
S2B_MSIL1C_20180807T105619_N0206_R094_T32VMJ_20180807T150742
S2A_MSIL1C_20180707T104021_N0206_R008_T32UPF_20180707T125205
S2B_MSIL1C_20180628T105619_N0206_R094_T32VMJ_20180629T091005
S2B_MSIL1C_20180718T110039_N0206_R094_T32VMJ_20180718T145209
S2B_MSIL1C_20180811T104019_N0206_R008_T32UPF_20180811T143244
S2A_MSIL1C_20180703T105621_N0206_R094_T32VMJ_20180703T130749
S2A_MSIL1C_20180713T105621_N0206_R094_T32VMJ_20180713T130920
S2A_MSIL1C_20180723T105621_N0206_R094_T32VMJ_20180723T130754
S2A_MSIL1C_20180816T104021_N0206_R008_T33VUC_20180816T164132
S2B_MSIL1C_20180801T104019_N0206_R008_T32UPF_20180801T161339
S2A_MSIL1C_20180816T104021_N0206_R008_T32UPF_20180816T164132
S2B_MSIL1C_20180821T104019_N0206_R008_T33VUC_20180821T144801
S2B_MSIL1C_20180728T105619_N0206_R094_T32VMJ_20180728T131913
S2A_MSIL1C_20180826T104021_N0206_R008_T33VUC_20180826T125219
S2A_MSIL1C_20180806T104021_N0206_R008_T33VUC_20180806T130931
S2A_MSIL1C_20180617T104021_N0206_R008_T33VUC_20180617T125156
S2A_MSIL1C_20180627T104021_N0206_R008_T32UPF_20180627T125110
S2B_MSIL1C_20180702T104019_N0206_R008_T33VUC_20180702T142357
S2B_MSIL1C_20180722T104019_N0206_R008_T33VUC_20180722T142325
S2B_MSIL1C_20180817T105619_N0206_R094_T32VMJ_20180817T131751
S2B_MSIL1C_20180801T104019_N0206_R008_T33VUC_20180801T161339
S2A_MSIL1C_20180812T105621_N0206_R094_T32VMJ_20180812T131737
S2B_MSIL1C_20180622T104019_N0206_R008_T32UPF_20180622T124339
S2A_MSIL1C_20180727T104021_N0206_R008_T33VUC_20180727T125155
S2A_MSIL1C_20180802T105621_N0206_R094_T32VMJ_20180802T132133
S2A_MSIL1C_20180617T104021_N0206_R008_T32UPF_20180617T125156
S2B_MSIL1C_20180827T110029_N0206_R094_T32VMJ_20180827T150823
S2B_MSIL1C_20180712T104019_N0206_R008_T33VUC_20180712T143102
S2B_MSIL1C_20180821T104019_N0206_R008_T32UPF_20180821T144801
S2B_MSIL1C_20180622T104019_N0206_R008_T33VUC_20180622T124339
S2B_MSIL1C_20180708T105619_N0206_R094_T32VMJ_20180708T134424
S2B_MSIL1C_20180811T104019_N0206_R008_T33VUC_20180811T143244
S2A_MSIL1C_20180627T104021_N0206_R008_T33VUC_20180627T125110
S2B_MSIL1C_20180702T104019_N0206_R008_T32UPF_20180702T142357
S2A_MSIL1C_20180822T105621_N0206_R094_T32VMJ_20180822T132540
S2A_MSIL1C_20180623T105621_N0206_R094_T32VMJ_20180623T130607
S2A_MSIL1C_20180806T104021_N0206_R008_T32UPF_20180806T130931
S2A_MSIL1C_20180826T104021_N0206_R008_T32UPF_20180826T125219
S2B_MSIL1C_20180722T104019_N0206_R008_T32UPF_20180722T142325
S2B_MSIL1C_20180618T105619_N0206_R094_T32VMJ_20180618T131745
S2A_MSIL1C_20180717T104021_N0206_R008_T32UPF_20180717T160515
S2B_MSIL1C_20180712T104019_N0206_R008_T32UPF_20180712T143102
S2A_MSIL1C_20180717T104021_N0206_R008_T33VUC_20180717T160515
S2A_MSIL1C_20180707T104021_N0206_R008_T33VUC_20180707T124148
@qsly09
Copy link
Contributor

qsly09 commented Nov 6, 2018

Thank you so much. This bug has been fixed out. Thanks again.

@dionhaefner
Copy link
Author

Sounds great, thanks! Is there an estimate when the new version will be available?

@drtscherer
Copy link

Is the fix available somewhere?

@qsly09
Copy link
Contributor

qsly09 commented Jan 19, 2019

Thank you very much for your feedback on this bug. We have really fixed this problem. Please update the Fmask tool along the same url (https://drive.google.com/drive/folders/1SXBnEBDJ1Kbv7IQ9qIgqloYHZfdP6O1O). Thanks again.

@j08lue
Copy link

j08lue commented Jan 24, 2019

@qsly09 Thanks a lot for your efforts! Will you also update Fmask_4_0.install (the Linux installer) with the fix?

@qsly09
Copy link
Contributor

qsly09 commented Jan 27, 2019

Sure. The version on Linux was also updated. Thanks.

@dionhaefner
Copy link
Author

@j08lue Will you do some tests? If this version works, we can close this issue.

@j08lue
Copy link

j08lue commented Nov 20, 2019

Can be closed @dionhaefner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants