Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About handling parent molecules in samples list #15

Open
Srilok opened this issue Apr 26, 2023 · 0 comments
Open

About handling parent molecules in samples list #15

Srilok opened this issue Apr 26, 2023 · 0 comments

Comments

@Srilok
Copy link

Srilok commented Apr 26, 2023

Hello,

In mols/glfownet.py, I noticed that you include the parents of m in samples list in _get_sample_model() (line 197 and line 203)

However, in the case we sample a null action (action==0), we only add m and not its parents (line 182). Is this a mistake, or am I missing something? Why is this case treated differently?

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant