Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to extract contributions independent of given bbox #256

Open
SlowMo24 opened this issue Feb 3, 2022 · 0 comments
Open
Labels
brainstorming Idea for a potential new feature or adaption that still needs further discussion comments welcome Indicates that the creator of this issue/PR is open for early review comments enhancement New feature or request

Comments

@SlowMo24
Copy link
Contributor

SlowMo24 commented Feb 3, 2022

Use Case Description

We extract contributions to elements where we know the ID and the geometry at a given point in time. We don't know the area in which contributions to that element occurred.
We have two approaches:

  1. we extract contributions with a global bbox -> all contributions are included (even if the element was moved over the globe and it is arguably not the same element any more, even if it is technically the same object, but that's a different discussion)
  2. we extract contributions within a buffer -> potentially not all contributions are returned and the buffer size is hard to choose. But the query is faster because the ID filter is faster.

Currently we do no. 1 but if the query times out, we will subdivide the bbox into smaller squares. We do not reduce the number of requested IDs (<1000 currently) because the bbox limit will do that automatically (if the elements never lay within the given bbox). Yet we will request many areas that are not related to our elements.

Request Description

If we had the possibility to extract all contributions by ID independent of the bbox (maybe only providing a hint: the element-bbox intersects with region XY), which I think is possible in OSHDB-API, we could speed up our workflow.

This would also enable the query: "Return all contributions to the filter-passing elements in this area." (currently it is "Return all contributions that took place in this area to the filter-passing elements in this area.").

Related: #250

@SlowMo24 SlowMo24 added enhancement New feature or request brainstorming Idea for a potential new feature or adaption that still needs further discussion comments welcome Indicates that the creator of this issue/PR is open for early review comments labels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brainstorming Idea for a potential new feature or adaption that still needs further discussion comments welcome Indicates that the creator of this issue/PR is open for early review comments enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant