Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website URL parameter names should be more precise #30

Closed
matthiasschaub opened this issue May 19, 2021 · 0 comments · Fixed by #61
Closed

Website URL parameter names should be more precise #30

matthiasschaub opened this issue May 19, 2021 · 0 comments · Fixed by #61
Assignees
@ElJocho
Labels
website
Milestone
Release 0.4.0

Comments

@matthiasschaub
Copy link
Collaborator

Currently the URL parameter for the website are topic which refers to report and countryID which refers to id of the selected region.

E.g. https://oqt.ohsome.org/?topic=MapActionPoc&countryID=43

I would rename topic to report and countryID to id to be more clear what those parameter are about.

In future an additional parameter will be required: dataset
@joker234 joker234 changed the title Website URL parameter names should be more precises Website URL parameter names should be more precise May 25, 2021
@joker234 joker234 added this to the Release 0.4.0 milestone Jun 7, 2021
ElJocho pushed a commit that referenced this issue Jun 21, 2021
addressed #30 and #5 additionally deleted unneeded function
60e467e
@ElJocho ElJocho mentioned this issue Jun 21, 2021
Merged
2 tasks
ElJocho added a commit that referenced this issue Jun 23, 2021
@ElJocho
Merge pull request #61 from GIScience/website_name_changes
afae451 
addressed #30 and #5 additionally deleted unneeded function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElJocho ElJocho

Labels
website
Projects
None yet
Milestone
Release 0.4.0
Development

Successfully merging a pull request may close this issue.

addressed #30 and #5 additionally deleted unneeded function GIScience/ohsome-quality-api
3 participants
@joker234 @ElJocho @matthiasschaub