Fixing saturation indicator bug

[hn437]

Prevent the mapping saturation indicator from returning nan-Values as result if data is available. See Issue #45 for bug description

Corresponding issue

Closes #45

New or changed dependencies

Checklist

• I have updated my branch to main (e.g. through git rebase main)
• My code follows the style guide and was checked with pre-commit before committing
• I have commented my code
• I have added sufficient unit and integration tests
• I have updated the CHANGELOG.md

[hn437]

Change to prevent the bug at the moment: Instead of checking a single parameter for nan-values, check all values within the 4 parameters for nan-values and use else-clause if nan-values do exist

[joker234]

Is inf a valid outcome we want to allow? If not you could reduce your check to something like this:

all(map(math.isfinite, a))

with a as your input list

[hn437]

Is inf a valid outcome we want to allow? If not you could reduce your check to something like this:

all(map(math.isfinite, a))

with a as your input list

no, but you need to check 2 lists and 2 floats which are all written in one tuple. therefore you need to handle the first to elements differently than the last two. and you need to check the results for each element within the nested list as well as the other float elements in the tuple

[hn437]

Is inf a valid outcome we want to allow? If not you could reduce your check to something like this:

all(map(math.isfinite, a))

with a as your input list

no, but you need to check 2 lists and 2 floats which are all written in one tuple. therefore you need to handle the first to elements differently than the last two. and you need to check the results for each element within the nested list as well as the other float elements in the tuple

so you could replace this:
validity_result = all( [ not x for x in map( math.isnan, [ math.fsum( inits5curves[0] ), math.fsum(inits5curves[1]), inits5curves[2], inits5curves[3], ], ) ] )
with this
validity_result = all( [ all(map(math.isfinite, inits5curves[0])), all(map(math.isfinite, inits5curves[1])), math.isfinite(inits5curves[2]), math.isfinite(inits5curves[3]), ] )

is this prefered?

[joker234]

…
so you could replace this:
validity_result = all( [ not x for x in map( math.isnan, [ math.fsum( inits5curves[0] ), math.fsum(inits5curves[1]), inits5curves[2], inits5curves[3], ], ) ] )
with this
validity_result = all( [ all(map(math.isfinite, inits5curves[0])), all(map(math.isfinite, inits5curves[1])), math.isfinite(inits5curves[2]), math.isfinite(inits5curves[3]), ] )

is this prefered?

I meant something like this, it's just a little bit shorter and you don't have to use that much nesting layers ;)

validity_result = all(map(math.isfinite, [*inits5curves[0] *inits5curves[1], inits5curves[2], inits5curves[3]]))

[hn437]

…
so you could replace this:
validity_result = all( [ not x for x in map( math.isnan, [ math.fsum( inits5curves[0] ), math.fsum(inits5curves[1]), inits5curves[2], inits5curves[3], ], ) ] )
with this
validity_result = all( [ all(map(math.isfinite, inits5curves[0])), all(map(math.isfinite, inits5curves[1])), math.isfinite(inits5curves[2]), math.isfinite(inits5curves[3]), ] )
is this prefered?

I meant something like this, it's just a little bit shorter and you don't have to use that much nesting layers ;)

validity_result = all(map(math.isfinite, [*inits5curves[0] *inits5curves[1], inits5curves[2], inits5curves[3]]))

Okay, thank you! Didn't knew you could use the * like that... implemented it!