Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website: fix issues, apply API changes from 0.5.0, Release 0.5.1 #132

Merged
merged 13 commits into from
Aug 17, 2021
Merged

Website: fix issues, apply API changes from 0.5.0, Release 0.5.1 #132

merged 13 commits into from
Aug 17, 2021

Conversation

joker234
Copy link
Member

@joker234 joker234 commented Aug 10, 2021 •
edited

Description

Clear up the website, the java script files, improve code quality, apply API breaking changes introduced in #100 and #130. Release 0.5.1.

Corresponding issue

None

New or changed dependencies

None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • [ ] I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

@joker234 joker234 added website code quality Related to our standards for 'good' code labels Aug 10, 2021
@matthiasschaub
Copy link
Collaborator

Changes made in #130 are also found in this PR. After implementing review feedback of #130 this branch has to be updated as well.

@joker234 joker234 changed the title 🚧 Website issues Website issues Aug 16, 2021
@matthiasschaub matthiasschaub modified the milestone: Release 0.5.0 Aug 17, 2021
matthiasschaub
matthiasschaub reviewed Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@matthiasschaub matthiasschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are looking good to me so far. Just a few very minor comments. I will test the changes locally and give another feedback.

@joker234 joker234 changed the title Website issues Website: fix issues, apply API changes from 0.5.0, Release 0.5.1 Aug 17, 2021
@matthiasschaub
Set reqest header content type to json
d509768 
of POST request from website to API
matthiasschaub
matthiasschaub previously approved these changes Aug 17, 2021
View reviewed changes
@joker234 joker234 merged commit 103aa08 into main Aug 17, 2021
@joker234 joker234 deleted the website-issues branch August 17, 2021 15:41
joker234 added a commit that referenced this pull request Aug 17, 2021
@joker234
add changelog for #132
12557b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd left review comments

@matthiasschaub matthiasschaub matthiasschaub approved these changes

Assignees
No one assigned
Labels
code quality Related to our standards for 'good' code website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joker234 @matthiasschaub @tyrasd