Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UML Component Diagram #136

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Aug 12, 2021

Corresponding issue

No related issue

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
    - [ ] My code follows the style guide and was checked with pre-commit before committing
    - [ ] I have commented my code
    - [ ] I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

joker234
joker234 previously approved these changes Aug 12, 2021
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason Reports, Indicators, Geodatabase, and Ohsome are all written with upper case? The Python modules are all written in lower case.

@matthiasschaub
Copy link
Collaborator Author

matthiasschaub commented Aug 13, 2021

Is there a reason Reports, Indicators, Geodatabase, and Ohsome are all written with upper case? The Python modules are all written in lower case.

At first api, cli and oqt were all just one file (one python module). The other ones where a lot of python modules (E.g. indicators).

But in this diagram I think it is okay to "paint the picture" in abstract terms. So I capitalized all module names. api.py is now just API.

@joker234 joker234 added this to the Release 0.5.0 milestone Aug 16, 2021
@matthiasschaub matthiasschaub merged commit 9e28159 into main Aug 16, 2021
@matthiasschaub matthiasschaub deleted the update-uml-component-diagram branch August 16, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants