Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and improve tests for API #168

Merged
merged 5 commits into from
Sep 29, 2021
Merged

Add and improve tests for API #168

merged 5 commits into from
Sep 29, 2021

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Sep 6, 2021 •
edited

Description

Add test cases covering the content of GeoJSON properties.

Improve API response schemata by using less logic to create the
schemata.

Corresponding issue

Closes #131

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub added the waiting for review This pull request urgently needs a code review label Sep 6, 2021
Hagellach37
Hagellach37 reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@Hagellach37 Hagellach37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
just a minor comment

workers/tests/integrationtests/api_response_schema.py Outdated Show resolved Hide resolved
workers/tests/integrationtests/api_response_schema.py Show resolved Hide resolved
@matthiasschaub matthiasschaub removed the waiting for review This pull request urgently needs a code review label Sep 10, 2021
@matthiasschaub
Copy link
Collaborator Author

@Hagellach37 please feel free to merge this branch if it nothing more needs to be changed.

joker234
joker234 reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Only two minor questions.

workers/tests/integrationtests/api_response_schema.py Outdated Show resolved Hide resolved
workers/tests/integrationtests/test_api_report_geojson_io.py Show resolved Hide resolved
@matthiasschaub
Add and improve tests for API
75b4a01 
Add test cases covering the content of GeoJSON properties.

Improve API response schemata by using less logic to create the
schemata.
@matthiasschaub
Improve docstring based on review
97f0181
@matthiasschaub
Define indicator properties only once
48afd36
@matthiasschaub matthiasschaub merged commit 07b6121 into main Sep 29, 2021
@matthiasschaub matthiasschaub deleted the test-api-response branch September 29, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

@Hagellach37 Hagellach37 Awaiting requested review from Hagellach37

Assignees

@Hagellach37 Hagellach37

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests covering the content of GeoJSON properties
3 participants
@matthiasschaub @joker234 @Hagellach37