Reworked and renamed LastEdit indicator to Currentness

[Gigaszi]

Description

Reworked and renamed the LastEdit indicator to Currentness. It now returns a histogram with the distribution of the latest contributions to an element for the whole timerange. New tresholds are defined.

Corresponding issue

Closes #

New or changed dependencies

Checklist

• I have updated my branch to main (e.g. through git rebase main)
• My code follows the style guide and was checked with pre-commit before committing
• I have commented my code
• I have added sufficient unit and integration tests
• I have updated the CHANGELOG.md

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

[Gigaszi]

In the current implementation here the indicator has a parameter, which allows to set a time range for the calculation. Currently the tests for test_api_indicator.py fail because of this implementation. To resolve this the parameter must also be set for all get/post/fetch functions of api.py. Do we want that or should the default value (last 10 years from current date) always apply?

[joker234]

Thanks for your work 👍

Apart from the suggestions/questions I have some general remarks:

• Before you do something else, have a look at the comments to the calculation and preprocessing of the indicator. Some suggestions might change other parts of your code as well.
• All descriptions in the metadata.yaml have to be applied to the new indicator.
• Some work should be put into the test. It's still called TestIndicatorLastEdit. You could think if it makes sense to check the actual results of your indicator. But this isn't a necessity, just worth thinking about.
• Why did you implement the parameter only into the CLI and not the API?
• Tests for the new parameter are missing.
• Changelog entry for the new parameter is missing.
• Please check your indicator with the API and especially the website (e.g. by temporarily adding it to a report).
• The output description needs to be aligned.

[joker234]

In the current implementation here the indicator has a parameter, which allows to set a time range for the calculation. Currently the tests for test_api_indicator.py fail because of this implementation. To resolve this the parameter must also be set for all get/post/fetch functions of api.py. Do we want that or should the default value (last 10 years from current date) always apply?

Sorry, missed that question before reviewing. Is there some kind of reasoning behind the last 10 years? Why not use all of the available data? Or 1 year? We could use a default time range like //P1Y if we want. This would give you not calendar years, but 1 year intervals from the first data timestamp. Alternatively you can automatically determine the first beginning of the next year. E.g. by using this: start_date = datetime.date(first_timestamp.year+1, 1, 1)

[joker234]

Some additional remarks, additionally to the not yet solved ones from the last review.

[joker234]

Please use numbers or words for numbers, not both. Example:

On the MapAction Lakes Count over 50% of the 3.0 edited elements were last edited in the last 7 years. More than half of the $elements edited elements were last edited between one and four years ago. This refers to medium data quality in respect to currentness.

[joker234]

Ideally it wouldn't say were edited in the last 1 years but were edited in the last year.

Matthias approved