Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change output format of the API endpoint /regions to a JSON Array of key-value maps #195

Merged
merged 6 commits into from
Oct 6, 2021
Merged

Change output format of the API endpoint /regions to a JSON Array of key-value maps #195

merged 6 commits into from
Oct 6, 2021

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Oct 5, 2021 •
edited

Description

  • Update API endpoint for fetching regions in website source code.
  • Rearrange CHANGELOG to reflect Breaking Changes.
  • API endpoint regions will return a JSON array of key-value maps instead of an nested array. Values are names and identifiers of the regions.

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub changed the title Fix regions endpoint Update API endpoint for fetching regions Oct 5, 2021
@matthiasschaub matthiasschaub mentioned this pull request Oct 5, 2021
Merged
3 tasks
@joker234 joker234 added this to the Release 0.6.0 milestone Oct 5, 2021
@matthiasschaub matthiasschaub changed the title Update API endpoint for fetching regions Change output format of CLI command list-regions and API endpoint /regions Oct 5, 2021
@matthiasschaub matthiasschaub force-pushed the fix-regions-endpoint branch 2 times, most recently from 8e97350 to e0b0358 Compare October 6, 2021 06:20
@matthiasschaub matthiasschaub changed the title Change output format of CLI command list-regions and API endpoint /regions Change output format of the API endpoint /regions to a JSONArray of a key-value map with names and identifies as values Oct 6, 2021
@matthiasschaub matthiasschaub changed the title Change output format of the API endpoint /regions to a JSONArray of a key-value map with names and identifies as values Change output format of the API endpoint /regions to a JSONvArray of a key-value map with names and identifies as values Oct 6, 2021
@matthiasschaub matthiasschaub changed the title Change output format of the API endpoint /regions to a JSONvArray of a key-value map with names and identifies as values Change output format of the API endpoint /regions to a JSONvArray of key-value maps Oct 6, 2021
@matthiasschaub matthiasschaub changed the title Change output format of the API endpoint /regions to a JSONvArray of key-value maps Change output format of the API endpoint /regions to a JSON Array of key-value maps Oct 6, 2021
joker234
joker234 reviewed Oct 6, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/geodatabase/client.py Show resolved Hide resolved
workers/tests/integrationtests/test_api.py Outdated Show resolved Hide resolved
workers/tests/integrationtests/test_api.py Outdated Show resolved Hide resolved
workers/tests/integrationtests/test_geodatabase.py Show resolved Hide resolved
matthiasschaub and others added 2 commits October 6, 2021 16:52
@matthiasschaub @joker234
Update CHANGELOG.md
53a269b 
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
@matthiasschaub
Improve test for list-regions command
10622d6
@matthiasschaub matthiasschaub merged commit 8839e92 into main Oct 6, 2021
@matthiasschaub matthiasschaub deleted the fix-regions-endpoint branch October 6, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthiasschaub @joker234