Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable support of the parameter bpolys for GET requests to the API #223

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Disable support of the parameter bpolys for GET requests to the API #223

merged 1 commit into from
Jan 14, 2022

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jan 4, 2022 •
edited

Description

Support GET request only for parameters dataset and featureId.

In othter words: It is no longer possible to make a GET request with the parameter bpolys.

Corresponding issue

Closes #192

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub changed the title Api post get API differentiate parameters for GET and POST requests Jan 4, 2022
@matthiasschaub matthiasschaub changed the title API differentiate parameters for GET and POST requests API differentiate parameters for GET and POST requests to endpoints indicator and report Jan 4, 2022
@matthiasschaub matthiasschaub force-pushed the api-post-get branch 2 times, most recently from 51a8a9b to 153f377 Compare January 10, 2022 11:07
@matthiasschaub matthiasschaub marked this pull request as ready for review January 10, 2022 11:07
@matthiasschaub matthiasschaub changed the title API differentiate parameters for GET and POST requests to endpoints indicator and report Disable support of the parameter bpolys for GET requests to the API Jan 12, 2022
@matthiasschaub matthiasschaub changed the title Disable support of the parameter bpolys for GET requests to the API Disable support of the parameter bpolys for GET requests to the API Jan 12, 2022
@matthiasschaub matthiasschaub force-pushed the api-post-get branch 3 times, most recently from e47ee3d to f61f909 Compare January 12, 2022 15:35
joker234
joker234 reviewed Jan 13, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/api/api.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/api/api.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/api/api.py Show resolved Hide resolved
workers/ohsome_quality_analyst/api/api.py Show resolved Hide resolved
workers/ohsome_quality_analyst/api/api.py Outdated Show resolved Hide resolved
joker234
joker234 previously approved these changes Jan 13, 2022
View reviewed changes
joker234
joker234 previously approved these changes Jan 13, 2022
View reviewed changes
docs/api.md Outdated Show resolved Hide resolved
joker234
joker234 previously approved these changes Jan 14, 2022
View reviewed changes
@matthiasschaub matthiasschaub force-pushed the api-post-get branch 3 times, most recently from b6abfc2 to 1654475 Compare January 14, 2022 09:54
@matthiasschaub matthiasschaub merged commit 4ec90ce into main Jan 14, 2022
@matthiasschaub matthiasschaub deleted the api-post-get branch January 14, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not support both GET and POST requests for indicator and report endpoints
2 participants
@matthiasschaub @joker234