new definitions for poi layers #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
matthiasschaub
requested changes
Mar 11, 2022
matthiasschaub
force-pushed
the
poi_definitions
branch
from
f53a7b1
to
27d667d
Compare
matthiasschaub
approved these changes
Mar 11, 2022
I updated the changelog myself. So from myside you can go ahead an merge this PR. I suggest to use squash and merge. Cheers :) |
SlowMo24
reviewed
Mar 11, 2022
| @@ -46,11 +46,68 @@ amenities: | |||
| filter: amenity=* and (type:way or type:node) | |||
|
|
|||
| poi: | |||
| name: Points-of-Interests | |||
| name: Points of interest | |||
| description: All features with the amenities key. | |||
There was a problem hiding this comment.
This can be misunderstood, because you use more than just the amanity key. Maybe you meant Amenities of public interest?
SlowMo24
reviewed
Mar 11, 2022
| description: | | ||
| A lot of different objects such related to natural features | ||
| transportation and amenities in a city. | ||
| A lot of different objects related to natural features, |
There was a problem hiding this comment.
This sounds a bit unprofessional, please rephrase.
SlowMo24
reviewed
Mar 11, 2022
| transportation and amenities in a city. | ||
| A lot of different objects related to natural features, | ||
| transportation and amenities in a city. Definition taken from | ||
| Waterproofing data project. |
There was a problem hiding this comment.
Source already given in source: tag
This was referenced Mar 15, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed old poi layer to landmarks and created new one based on openpoiservice. Removed idel_vgi_poi layer.
Corresponding issue
Closes #161
Related #259
Checklist
main(e.g. throughgit rebase main)