Check for invalid indicator layer combination during initialization of indicator objects #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasschaub
changed the title
matthiasschaub
force-pushed
the
invalid-indicator-layer-combination
branch
from
0178144
to
3898ae8
Compare
matthiasschaub
changed the title
joker234
requested changes
May 20, 2021
There was a problem hiding this comment.
Some minor suggestions. Thx for implementing this check.
In general it would be nice if the (API) user would get more feedback about the actual exceptions. Most of the time they get Internal Server Error. See also #29 (comment)
matthiasschaub
force-pushed
the
invalid-indicator-layer-combination
branch
from
d8c16bb
to
a2628e2
Compare
matthiasschaub
force-pushed
the
invalid-indicator-layer-combination
branch
from
bdfb994
to
9424243
Compare
joker234
previously approved these changes
May 27, 2021
Check for invalid indicator layer combination during initialization of indicator objects. Improve unittests of custom errors Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org> Recreate VCR cassette Improve custom exception message Make unittest for custom excepetion more clear Add test for layer with not second filter Update changelog Use built-in ValueError instead of custom Error
matthiasschaub
force-pushed
the
invalid-indicator-layer-combination
branch
from
9424243
to
99c57d3
Compare
|
@joker234 since I rebased (squashed) the commits your approval is not longer sufficient for GitHub to let me merge the PR. I did not make any changes to the code. Could you again approve the PR? |
joker234
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding issue
Closes #24
Checklist
main(e.g. throughgit rebase main)