Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out template logic to own module #302

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Factor out template logic to own module #302

merged 2 commits into from
Apr 27, 2022

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Apr 25, 2022 •
edited

Description

Create a html_templates module with *-template.html and html_templates.py containing a function get_template().

Corresponding issue

Closes #285

New or changed dependencies

  • None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub
Factor out template logic to own module
6e6fad3 
Create a `html_templates` module with *-template.html and
html_templates.py containing a function `get_template()`.
@matthiasschaub matthiasschaub added this to the Release 0.10.0 milestone Apr 25, 2022
joker234
joker234 reviewed Apr 26, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@matthiasschaub @joker234
Update CHANGELOG.md
537447e 
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
@joker234 joker234 self-requested a review April 27, 2022 08:40
@matthiasschaub matthiasschaub merged commit 45b4a0d into main Apr 27, 2022
@matthiasschaub matthiasschaub deleted the html-template branch April 27, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gigaszi Gigaszi Gigaszi approved these changes

@joker234 joker234 Awaiting requested review from joker234

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.10.0
Development

Successfully merging this pull request may close these issues.

Factor out template logic to own module
3 participants
@matthiasschaub @joker234 @Gigaszi