Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'flatten' parameter to API request #303

Merged
merged 2 commits into from
May 4, 2022
Merged

Add 'flatten' parameter to API request #303

merged 2 commits into from
May 4, 2022

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Apr 25, 2022 •
edited

Description

Make flatten of GeoJSON properties of Indicators and Reports optional.

Corresponding issue

Continue work of #247
Closes #281

New or changed dependencies

  • None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub marked this pull request as draft April 25, 2022 07:38
@matthiasschaub matthiasschaub added this to the Release 0.10.0 milestone Apr 25, 2022
@matthiasschaub matthiasschaub force-pushed the add-flatten-param-api branch 2 times, most recently from 30f06bb to 28988bc Compare April 25, 2022 16:40
@matthiasschaub matthiasschaub marked this pull request as ready for review April 25, 2022 16:40
@matthiasschaub matthiasschaub added enhancement New feature or request api labels Apr 27, 2022
@matthiasschaub matthiasschaub mentioned this pull request Apr 28, 2022
Closed
joker234
joker234 previously approved these changes Apr 29, 2022
View reviewed changes
joker234
joker234 previously approved these changes May 3, 2022
View reviewed changes
@matthiasschaub matthiasschaub merged commit 2486e70 into main May 4, 2022
@matthiasschaub matthiasschaub deleted the add-flatten-param-api branch May 4, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
api enhancement New feature or request
Projects
None yet
Milestone
Release 0.10.0
Development

Successfully merging this pull request may close these issues.

Add parameter to API request to make flatten of properties optional
2 participants
@matthiasschaub @joker234