Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make calculation of an Indicator for a FeatureCollection or for a Report asynchronous #307

Merged
merged 1 commit into from
May 4, 2022
Merged

Make calculation of an Indicator for a FeatureCollection or for a Report asynchronous #307

merged 1 commit into from
May 4, 2022

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Apr 25, 2022 •
edited

Description

Make calculation of an Indicator for a FeatureCollection or for a Report asynchronous

Corresponding issue

Closes #305

New or changed dependencies

  • None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
    • Not sure. Are more test needed?
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub changed the title Make calculation of indicators for a FeatureCollection and of a Report asynchronous Make calculation of an Indicator for a FeatureCollection or for a Report asynchronous Apr 25, 2022
@matthiasschaub matthiasschaub added this to the Release 0.10.0 milestone Apr 25, 2022
@matthiasschaub matthiasschaub marked this pull request as ready for review April 25, 2022 13:15
@matthiasschaub matthiasschaub added the enhancement New feature or request label Apr 27, 2022
joker234
joker234 reviewed Apr 29, 2022
View reviewed changes
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I have added sufficient unit and integration tests
    • Not sure. Are more test needed?

Not sure what would be tested. I think it's okay to not add any more tests, apart from the consideration in the one comment I made to this topic.

workers/ohsome_quality_analyst/oqt.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/oqt.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/oqt.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/oqt.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/utils/helper.py Show resolved Hide resolved
workers/ohsome_quality_analyst/utils/helper.py Show resolved Hide resolved
workers/ohsome_quality_analyst/oqt.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/oqt.py Outdated Show resolved Hide resolved
@matthiasschaub matthiasschaub mentioned this pull request May 2, 2022
Merged
11 tasks
joker234
joker234 previously approved these changes May 3, 2022
View reviewed changes
joker234
joker234 previously approved these changes May 3, 2022
View reviewed changes
joker234
joker234 previously approved these changes May 4, 2022
View reviewed changes
@matthiasschaub
async calc of indicators for multiple features
e7fb421 
Make calculation of an Indicator for a FeatureCollection or a Report
asynchronous.
@matthiasschaub matthiasschaub merged commit 9ca4bf9 into main May 4, 2022
@matthiasschaub matthiasschaub deleted the async-feature-collection branch May 4, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 0.10.0
Development

Successfully merging this pull request may close these issues.

Make calculation of indicators for a FeatureCollection or a Report asynchronous
2 participants
@matthiasschaub @joker234