Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix semaphore instantiation outside of event-loop #346

Merged
merged 1 commit into from
Jun 2, 2022
Merged

fix semaphore instantiation outside of event-loop #346

merged 1 commit into from
Jun 2, 2022

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jun 1, 2022 •
edited

Description

Semaphore needs to be instantiated inside of the running event-loop.

Replace function sem_task with gather_with_semaphore function.
The semaphore will be instantiated in this function and not as default
argument of the function.

Corresponding issue

  • None

New or changed dependencies

  • None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub marked this pull request as ready for review June 2, 2022 08:50
@matthiasschaub matthiasschaub changed the title Fix async semaphore fix semaphore instantiation outside of event-loop Jun 2, 2022
joker234
joker234 previously approved these changes Jun 2, 2022
View reviewed changes
joker234
joker234 previously approved these changes Jun 2, 2022
View reviewed changes
@matthiasschaub
fix semaphore instantiation outside of event-loop
60c1100 
Semaphore needs to be instantiated inside of the running event-loop.

Replace function `sem_task` with `gather_with_semaphore` function.
The semaphore will be instantiated in this function and not as default
argument of the function.ip
@matthiasschaub matthiasschaub merged commit 989cef2 into main Jun 2, 2022
@matthiasschaub matthiasschaub deleted the fix-async-semaphore branch June 2, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthiasschaub @joker234