Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake8 plugin pep8-naming as development dependency #40

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Add flake8 plugin pep8-naming as development dependency #40

merged 2 commits into from
Jun 1, 2021

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented May 31, 2021 •
edited by joker234

Description

  • Add flake8-naming package as dev dependency.
  • Add configuration to ignore flake8-naming warnings for Python files in indicators/mapping-saturation/

New or changed dependencies

  • pep8-naming

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • [ ] My code follows the style guide and was checked with pre-commit before committing
  • [ ] I have commented my code
  • [ ] I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub force-pushed the add-opt-dev-packages branch 2 times, most recently from ab27100 to b341574 Compare June 1, 2021 07:25
@matthiasschaub matthiasschaub marked this pull request as ready for review June 1, 2021 07:26
@matthiasschaub matthiasschaub added code quality Related to our standards for 'good' code waiting for review This pull request urgently needs a code review labels Jun 1, 2021
@matthiasschaub matthiasschaub changed the title Add optional pep8-naming package as dev dependency Add flake8-bugbear and pep8-naming packages as optional dependencies Jun 1, 2021
@matthiasschaub matthiasschaub changed the title Add flake8-bugbear and pep8-naming packages as optional dependencies Add additional flake8 plugins Jun 1, 2021
joker234
joker234 reviewed Jun 1, 2021
View reviewed changes
workers/setup.cfg Show resolved Hide resolved
workers/setup.cfg Outdated Show resolved Hide resolved
@matthiasschaub matthiasschaub changed the title Add additional flake8 plugins Add flake8 plugin pep-naming as development dependency Jun 1, 2021
joker234
joker234 reviewed Jun 1, 2021
View reviewed changes
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions. One further comment: it would be nice if you could split the commits in one (or more) adding the functionality and one (or more) changing the code or applying fixes to the issues.

CHANGELOG.md Outdated Show resolved Hide resolved
workers/setup.cfg Outdated Show resolved Hide resolved
@joker234 joker234 changed the title Add flake8 plugin pep-naming as development dependency Add flake8 plugin pep8-naming as development dependency Jun 1, 2021
joker234
joker234 previously approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be aware of my comment in the last review: #40 (review)

@joker234 joker234 removed the waiting for review This pull request urgently needs a code review label Jun 1, 2021
@matthiasschaub matthiasschaub merged commit 3284427 into main Jun 1, 2021
@matthiasschaub matthiasschaub deleted the add-opt-dev-packages branch June 1, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
code quality Related to our standards for 'good' code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthiasschaub @joker234