-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: result value above 100% for mapping saturation #479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File: indicator.py
The additions are good, but I would keep the else statement at the end of the elif statements to catch unexpected values should they unexpectedly occure
File: test_indicator_mapping_saturation.py
no further change requested
workers/ohsome_quality_analyst/indicators/mapping_saturation/indicator.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this addition. I would squash existing commits into one.
* feat: add classification and plot creation for over 100% results * feat: new indicator classification * add: revert else-statement --------- Co-authored-by: Levi Szamek <levi.szamek@stud.uni-heidelberg.de> Co-authored-by: Jonas <36933111+hn437@users.noreply.github.com>
* feat: add classification and plot creation for over 100% results * feat: new indicator classification * add: revert else-statement --------- Co-authored-by: Levi Szamek <levi.szamek@stud.uni-heidelberg.de> Co-authored-by: Jonas <36933111+hn437@users.noreply.github.com>
Corresponding issue
Closes #282, #283
New or changed dependencies
Checklist
main
(e.g. throughgit rebase main
)