Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Plotly figure to Mapping Saturation #499

Merged
merged 16 commits into from
Mar 30, 2023
Merged

feat: add Plotly figure to Mapping Saturation #499

merged 16 commits into from
Mar 30, 2023

Conversation

Gigaszi
Copy link
Contributor

@Gigaszi Gigaszi commented Mar 7, 2023 •
edited

Description

Add a plot creation via plotly to the MappingSaturation indicator. This will be created in a seperate function and will not replace the SVG via Matplotlib for now.

Corresponding issue

#489

New or changed dependencies

  • plotly

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub marked this pull request as draft March 8, 2023 13:30
@matthiasschaub
Copy link
Collaborator

matthiasschaub commented Mar 8, 2023 •
edited

I would suggest keeping the create_figure function for now and add a new one create_figure_plotly this way we could support both figures for a while.
I would store the plotly figure at result.figure.

@matthiasschaub matthiasschaub marked this pull request as ready for review March 28, 2023 15:42
@matthiasschaub matthiasschaub changed the title Plotly mapping saturation 🚧 feat: add Plotly figure to Mapping Saturation Mar 28, 2023
matthiasschaub and others added 2 commits March 30, 2023 11:17
@matthiasschaub
fix(mapping-saturation): legend placement
0ece0f4 
do not configure legend placement to avoid shadowing the y-axis label.
Default is upper-right corner.
@matthiasschaub
Merge branch 'main' into plotly_mapping_saturation
864e27d
@matthiasschaub matthiasschaub merged commit 80500fa into main Mar 30, 2023
@matthiasschaub matthiasschaub deleted the plotly_mapping_saturation branch March 30, 2023 13:43
@joker234 joker234 mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gigaszi @matthiasschaub @joker234 @hn437