breaking: rename Tag Ratio to Attribute Completeness #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasschaub
requested changes
Mar 14, 2023
There was a problem hiding this comment.
Be aware of changes to the indicator key format (#398). I made suggestions what changes are needed.
Please also update the changelog (Its a Breaking Change)
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| TagsRatio: | |||
| name: Tags Ratio | |||
| AttributeCompleteness: | |||
There was a problem hiding this comment.
Suggested change
| AttributeCompleteness: | |
| attribute-completeness: |
| @@ -14,7 +14,7 @@ def __init__( | |||
| indicator_layer=( | |||
| IndicatorLayer("MappingSaturation", "building_count"), | |||
| IndicatorLayer("Currentness", "building_count"), | |||
| IndicatorLayer("TagsRatio", "building_count"), | |||
| IndicatorLayer("AttributeCompleteness", "building_count"), | |||
There was a problem hiding this comment.
Suggested change
| IndicatorLayer("AttributeCompleteness", "building_count"), | |
| IndicatorLayer("attribute-completeness", "building_count"), |
| @@ -15,7 +15,7 @@ def __init__( | |||
| indicator_layer=( | |||
| IndicatorLayer("MappingSaturation", "major_roads_length"), | |||
| IndicatorLayer("Currentness", "major_roads_count"), | |||
| IndicatorLayer("TagsRatio", "major_roads_length"), | |||
| IndicatorLayer("AttributeCompleteness", "major_roads_length"), | |||
There was a problem hiding this comment.
Suggested change
| IndicatorLayer("AttributeCompleteness", "major_roads_length"), | |
| IndicatorLayer("attribute-completeness", "major_roads_length"), |
| @@ -79,7 +79,7 @@ def test_get_valid_indicators(self): | |||
| "GhsPopComparisonBuildings", | |||
| "MappingSaturation", | |||
| "Currentness", | |||
| "TagsRatio", | |||
| "AttributeCompleteness", | |||
There was a problem hiding this comment.
Suggested change
| "AttributeCompleteness", | |
| "attribute-completeness", |
matthiasschaub
approved these changes
Mar 22, 2023
matthiasschaub
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding issue
Closes #493
New or changed dependencies
Checklist
main(e.g. throughgit rebase main)