Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api)!: rename layerKey and layer to topic #501

Merged
merged 3 commits into from
Mar 14, 2023
Merged

refactor(api)!: rename layerKey and layer to topic #501

merged 3 commits into from
Mar 14, 2023

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Mar 14, 2023 •
edited

Description

BREAKING CHANGE: Rename API parameter layerKey and layer to topic

Corresponding issue

Related Issue #502
Closes #491

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have updated the CHANGELOG.md
  • update test parameters

@matthiasschaub matthiasschaub added waiting for review This pull request urgently needs a code review breaking This will break previous versions. Documentation and Changelog update compulsory api topic labels Mar 14, 2023
@matthiasschaub matthiasschaub marked this pull request as ready for review March 14, 2023 09:57
@matthiasschaub matthiasschaub removed the waiting for review This pull request urgently needs a code review label Mar 14, 2023
@matthiasschaub matthiasschaub marked this pull request as draft March 14, 2023 09:57
@matthiasschaub matthiasschaub force-pushed the layer-to-topic branch 2 times, most recently from 7deeba8 to 24d591a Compare March 14, 2023 16:25
@matthiasschaub
refactor(api)!: rename layerKey and layer to topic
ebcc4c2 
BREAKING CHANGE: Rename API parameter `layerKey` and `layer` to `topic`
@matthiasschaub matthiasschaub marked this pull request as ready for review March 14, 2023 16:28
matthiasschaub and others added 2 commits March 14, 2023 17:43
@matthiasschaub @joker234
fix typos
548ef6f 
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
@matthiasschaub
test: recreate VCR cassettes
0a70fe1
@matthiasschaub matthiasschaub merged commit 7d5a497 into main Mar 14, 2023
@matthiasschaub matthiasschaub deleted the layer-to-topic branch March 14, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
api breaking This will break previous versions. Documentation and Changelog update compulsory topic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: Rename layer to topic
2 participants
@matthiasschaub @joker234