Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete jrc layers and report #503

Merged
merged 7 commits into from
Mar 21, 2023
Merged

delete jrc layers and report #503

merged 7 commits into from
Mar 21, 2023

Conversation

Gigaszi
Copy link
Contributor

@Gigaszi Gigaszi commented Mar 14, 2023

Closes #51

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have updated the CHANGELOG.md

CHANGELOG.md Outdated
Comment on lines 12 to 16
- remove JRC related layers and report `jrc_requirements` ([#503])

### How to Upgrade


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its not necessary to add this change to how to upgrade section. But I would move this from the Other Changes to Breaking Changes section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -33,6 +36,7 @@
| `includeHtml` | `include-html` |
| `featureId` | `feature-id` |
| `fidField` | `indicators` |
>>>>>>> main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>>>>>>> main

CHANGELOG.md Outdated Show resolved Hide resolved
@matthiasschaub matthiasschaub merged commit f21e163 into main Mar 21, 2023
@matthiasschaub matthiasschaub deleted the jcr_deletion branch March 21, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layer definition of JRC is unclear
2 participants