Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mapping-saturation): add missing edge case detection for too few data points. #512

Merged
merged 5 commits into from
Mar 20, 2023
Merged

fix(mapping-saturation): add missing edge case detection for too few data points. #512

merged 5 commits into from
Mar 20, 2023

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Mar 20, 2023 •
edited

Description

  • fix(mapping-saturation): add missing edge case detection for too few data points.
  • test(mapping-saturation): add and rewrite tests
    • add tests for checking edge cases
    • rewrite tests to use pytest instead of unittest
    • introduce new session wide fixtures in conftest

Corresponding issue

Closes #507

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub changed the title Fix ms few data points fix(mapping-saturation): Add missing edge case detection for too few data points. Mar 20, 2023
@matthiasschaub matthiasschaub changed the title fix(mapping-saturation): Add missing edge case detection for too few data points. fix(mapping-saturation): add missing edge case detection for too few data points. Mar 20, 2023
@matthiasschaub matthiasschaub marked this pull request as ready for review March 20, 2023 14:49
@matthiasschaub
fix(mapping-saturation): missing edge case
97350d8 
Add missing edge case detection for too few data points.

Closes #507
joker234
joker234 reviewed Mar 20, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
joker234
joker234 previously approved these changes Mar 20, 2023
View reviewed changes
@matthiasschaub
test(mapping-saturation): add and rewrite tests
3fdafd0 
- add tests for checking edge cases
- rewrite tests to use pytest instead of unittest
- introduce new session wide fixtures in conftest
@matthiasschaub
chore(changelog): update
30b0e86
@matthiasschaub
refactor(mapping-saturation): change latest value
3e8faa3 
Change `self.latest_value` to `self.values[-1]`
joker234
joker234 previously approved these changes Mar 20, 2023
View reviewed changes
@matthiasschaub matthiasschaub merged commit 08e8ee1 into main Mar 20, 2023
@matthiasschaub matthiasschaub deleted the fix-ms-few-data-points branch March 20, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal Server Error when requesting the Mapping Saturation Indicator with to few data points
2 participants
@matthiasschaub @joker234