Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and Tidy up filters and topic definitions #520

Merged
merged 7 commits into from
Mar 24, 2023
Merged

Fix and Tidy up filters and topic definitions #520

merged 7 commits into from
Mar 24, 2023

Conversation

joker234
Copy link
Member

Description

Fix and Tidy up filters and topic definitions

Corresponding issue

None

New or changed dependencies

None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@joker234 joker234 added the topic label Mar 22, 2023
matthiasschaub
matthiasschaub approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@matthiasschaub matthiasschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks :)

@joker234 joker234 merged commit 29fafc2 into main Mar 24, 2023
@joker234 joker234 deleted the tidy-up-filters branch March 24, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasschaub matthiasschaub matthiasschaub approved these changes

Assignees
No one assigned
Labels
topic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joker234 @matthiasschaub