Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move base/topic.py to topics/models.py & topics.yaml to topics/presets.yaml #523

Merged
merged 3 commits into from
Mar 30, 2023
Merged

refactor: move base/topic.py to topics/models.py & topics.yaml to topics/presets.yaml #523

merged 3 commits into from
Mar 30, 2023

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Mar 27, 2023 •
edited

PyCharm refactor methods used:

  • Move File ...
  • Rename ...

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub changed the title Refactor models refactor: move topic.py from /base to /topics/models.py & topics.yaml to topics/preset.yaml Mar 27, 2023
@matthiasschaub matthiasschaub changed the title refactor: move topic.py from /base to /topics/models.py & topics.yaml to topics/preset.yaml refactor: move base/topic.py to topics/models.py & topics.yaml to topics/preset.yaml Mar 27, 2023
@matthiasschaub matthiasschaub marked this pull request as ready for review March 27, 2023 14:34
@matthiasschaub matthiasschaub changed the title refactor: move base/topic.py to topics/models.py & topics.yaml to topics/preset.yaml refactor: move base/topic.py to topics/models.py & topics.yaml to topics/presets.yaml Mar 27, 2023
joker234
joker234 reviewed Mar 28, 2023
View reviewed changes
docs/indicator_creation.md Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/topics/models.py Outdated Show resolved Hide resolved
joker234
joker234 reviewed Mar 28, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@matthiasschaub matthiasschaub merged commit 8494ff9 into main Mar 30, 2023
1 check passed
@matthiasschaub matthiasschaub deleted the refactor-models branch March 30, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthiasschaub @joker234