Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve currentness indicator #535

Merged
merged 25 commits into from
Apr 19, 2023
Merged

improve currentness indicator #535

merged 25 commits into from
Apr 19, 2023

Conversation

Gigaszi
Copy link
Contributor

@Gigaszi Gigaszi commented Apr 4, 2023

Description

Add SVG creation with plotly and remove old SVG creation with matplotlib. Contribution requests now exclude deletions. Removed unnecessary request to ohsome API. Contribution are now aggregated to yearly buckets instead of per year. Overall, we reduced the requests to the ohsome API from 4 to 2.

Corresponding issue

Closes #508
Closes #459
Closes #546
Related #348

New or changed dependencies

  • None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub
Copy link
Collaborator

Will this PR close #459 and #508 ? Then I recommend updating the PR description.

@matthiasschaub
Copy link
Collaborator

After #536 is merged, you can substitute the usage of matplotlib in the create_figure function with usage of plotly

@Gigaszi Gigaszi changed the title 🚧 fix: currentness indicator improve currentness indicator Apr 11, 2023
CHANGELOG.md Outdated
@@ -24,7 +25,7 @@
- layer/topic are now pydantic models instead of dataclasses ([#517])
- add plot creation via plotly to `MappingSaturation` indicator ([#499])
- api: add `/metadata/topic` endpoint ([#519])
- api: add `/metadata/indicators` endpoint ([#533])
- api: add `/metadata/indicators` endpoint ([#533])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- api: add `/metadata/indicators` endpoint ([#533])
- api: add `/metadata/indicators` endpoint ([#533])

@matthiasschaub matthiasschaub merged commit ce47e59 into main Apr 19, 2023
1 check passed
@matthiasschaub matthiasschaub deleted the rework_currentness branch April 19, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use plotly in currentness indicator Currentness Indicator: perform only one request
2 participants