Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: substitute matplotlib SVG with plotly SVG #536

Merged
merged 5 commits into from
Apr 5, 2023
Merged

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Apr 4, 2023

Description

Substitute SVG created by matplotlib of the Mapping Saturation indicator
by a SVG created by plotly

image

Corresponding issue

Closes #

New or changed dependencies

  • add Kaleido for creating SVGs

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub changed the title Ms plotly svg feat: substitute matplotlib SVG with plotly SVG Apr 4, 2023
@matthiasschaub matthiasschaub marked this pull request as ready for review April 4, 2023 14:59
@matthiasschaub matthiasschaub mentioned this pull request Apr 5, 2023
5 tasks
joker234
joker234 previously approved these changes Apr 5, 2023
workers/pyproject.toml Outdated Show resolved Hide resolved
@matthiasschaub matthiasschaub merged commit a2cd1f6 into main Apr 5, 2023
1 check passed
@matthiasschaub matthiasschaub deleted the ms-plotly-svg branch April 5, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants