Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining metadata endpoints #545

Merged
merged 25 commits into from
Apr 19, 2023
Merged

Add remaining metadata endpoints #545

merged 25 commits into from
Apr 19, 2023

Conversation

joker234
Copy link
Member

@joker234 joker234 commented Apr 12, 2023 •
edited

Description

This PR introduces:

  • the /metadata endpoint containing all metadata from /metadata/{topics,indicators,reports}
  • the /metadata/reports endpoint
  • limit metadata endpoints by projects
  • the use of the core project as default for metadata requests
  • assigns indicators and reports to projects

Corresponding issue

New or changed dependencies

None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@joker234 joker234 added enhancement New feature or request api labels Apr 12, 2023
@joker234 joker234 self-assigned this Apr 12, 2023
@joker234 joker234 mentioned this pull request Apr 12, 2023
Closed
3 tasks
matthiasschaub
matthiasschaub reviewed Apr 18, 2023
View reviewed changes
workers/ohsome_quality_analyst/api/response_models.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/definitions.py Outdated Show resolved Hide resolved
workers/tests/conftest.py Outdated Show resolved Hide resolved
workers/tests/integrationtests/api/conftest.py Outdated Show resolved Hide resolved
workers/tests/integrationtests/api/conftest.py Outdated Show resolved Hide resolved
workers/tests/integrationtests/api/test_metadata.py Outdated Show resolved Hide resolved
workers/tests/integrationtests/api/test_metadata.py Outdated Show resolved Hide resolved
workers/tests/integrationtests/api/test_metadata_topics.py Outdated Show resolved Hide resolved
workers/tests/integrationtests/api/test_metadata_reports.py Outdated Show resolved Hide resolved
@joker234
feat(api): add general /metadata endpoint
2346f75
@joker234
test(api): add test for /metadata endpoint
2107496
@joker234
feat(api): add report metadata endpoints
3a24b00
@joker234
test(api): add test for /metadata/reports endpoints
b6e5c41
@joker234
feat(api): limit the metadata topic response by project
d76461d
@joker234
test(api): add tests for topic filter by project
20b15f9
@joker234
feat(api): add projects to indicators
2bbe9dd
@joker234
feat(api): limit the metadata indicator response by project
e1e2ece
@joker234
test(api): enable tests for metadata indicators filtered by project
3bdffd5
@joker234
feat(api): add projects to reports
f6f8ae0
@joker234
feat(api): limit the metadata report response by project
c9c454e
@joker234
test(api): enable tests for metadata reports filtered by project
3adc5c5
@joker234
feat(api): change metadata response from list to dict
5c94cd4
@joker234
feat(api): remove key from metadata topic output
f50eb59
@joker234
style(definitions): improve code style in definitions.py
f2bd6c7
@joker234
style(tests): improve fixture names
190215e
@joker234
style(tests): fix unused fixture imports
691f1fb
@joker234
tests(metadata): fix todo
2fdf719
@joker234
style(tests): fix unused fixture imports
f3ad99b
@joker234
style(models): rename Metadata Response Models
eed0ece
@joker234
fix(api): return key as dict key for single metadata requests and ren…
26e9547 
…ame Response Models
@joker234
feat(reports): mark multilevel-mapping-saturation report as core
4da308d
@joker234 joker234 merged commit e399522 into main Apr 19, 2023
1 check passed
@joker234 joker234 deleted the add-metadata-endpoints branch April 19, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasschaub matthiasschaub matthiasschaub approved these changes

Assignees

@joker234 joker234

Labels
api enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add project or namespace attribute to layers and indicators
2 participants
@joker234 @matthiasschaub