Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plotly building completeness #552

Merged
merged 13 commits into from
May 11, 2023
Merged

Plotly building completeness #552

merged 13 commits into from
May 11, 2023

Conversation

Gigaszi
Copy link
Contributor

@Gigaszi Gigaszi commented Apr 17, 2023 •
edited by matthiasschaub

Description

Add SVG creation with plotly to building-area indicator.

Corresponding issue

Closes #548

New or changed dependencies

  • None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@Gigaszi Gigaszi changed the title Plotly building completeness 🚧 Plotly building completeness Apr 25, 2023
@Gigaszi
Copy link
Contributor Author

Gigaszi commented Apr 25, 2023

image
This is how the plot currently looks like? Feedback is welcome. I think we need here more description too. Maybe you have some suggestions

matthiasschaub
matthiasschaub reviewed May 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@matthiasschaub matthiasschaub mentioned this pull request May 11, 2023
Closed
@matthiasschaub matthiasschaub merged commit 3a33812 into main May 11, 2023
2 checks passed
@matthiasschaub matthiasschaub deleted the plotly_building_completeness branch May 11, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasschaub matthiasschaub matthiasschaub approved these changes

Assignees
No one assigned
Labels
indicator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use plotly in completeness indicators
2 participants
@Gigaszi @matthiasschaub