Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quality dimensions to indicators #561

Merged
merged 13 commits into from
May 2, 2023
Merged

Add quality dimensions to indicators #561

merged 13 commits into from
May 2, 2023

Conversation

joker234
Copy link
Member

@joker234 joker234 commented Apr 27, 2023

Description

This PR introduces quality dimensions (as model) to all indicators. These indicate what quality category or dimension an indicator is supposed to represent.

Corresponding issue

Closes #532

New or changed dependencies

None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md
  • fix TODO descriptions

workers/ohsome_quality_analyst/api/api.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/api/api.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/api/api.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/api/response_models.py Outdated Show resolved Hide resolved
Co-authored-by: Matthias Schaub <83658582+matthiasschaub@users.noreply.github.com>
@joker234 joker234 merged commit 0595706 into main May 2, 2023
2 checks passed
@joker234 joker234 deleted the add-quality-dimensions branch May 2, 2023 07:11
@joker234 joker234 mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add quality dimension label to each indicator
2 participants