Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(vcr): don't record local requests and change cassettes directory structure #579

Merged
merged 7 commits into from
Jun 20, 2023
Merged

tests(vcr): don't record local requests and change cassettes directory structure #579

merged 7 commits into from
Jun 20, 2023

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jun 19, 2023 •
edited by joker234

Description

VCR: don't record local requests and change cassettes directory structure

Corresponding issue

None

New or changed dependencies

None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md
  • Update VCR Cassettes

@matthiasschaub matthiasschaub marked this pull request as ready for review June 20, 2023 07:44
@joker234 joker234 changed the title tests(vcr): don´t record requests to local FastAPI tests(vcr): don't record local requests and change cassettes directory structure Jun 20, 2023
@joker234 joker234 self-requested a review June 20, 2023 07:49
@joker234 joker234 added CI Related to continuous integration (unit tests, build settings, etc.) tests Issues with tests labels Jun 20, 2023
@joker234 joker234 added this to the Release 0.15.0 milestone Jun 20, 2023
joker234
joker234 previously approved these changes Jun 20, 2023
View reviewed changes
@joker234 joker234 merged commit 067afdc into main Jun 20, 2023
2 checks passed
@joker234 joker234 deleted the tests-vcr-ignore-localhost branch June 20, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
CI Related to continuous integration (unit tests, build settings, etc.) tests Issues with tests
Projects
None yet
Milestone
Release 0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthiasschaub @joker234