Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): support json response for requests to /indicator endpoint via `accept' header #582

Merged
merged 7 commits into from
Jun 27, 2023
Merged

feat(api): support json response for requests to /indicator endpoint via `accept' header #582

merged 7 commits into from
Jun 27, 2023

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jun 20, 2023 •
edited

Description

Follow up issues:

Corresponding issue

Closes #569

New or changed dependencies

None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md
  • Set possible header so one can select a header in the swagger UI

@matthiasschaub matthiasschaub force-pushed the api-json-response branch 3 times, most recently from 2d8fe4a to 2dec369 Compare June 22, 2023 13:57
@matthiasschaub matthiasschaub marked this pull request as ready for review June 22, 2023 13:59
@joker234 joker234 added this to the Release 0.15.0 milestone Jun 26, 2023
@joker234 joker234 added enhancement New feature or request api breaking This will break previous versions. Documentation and Changelog update compulsory labels Jun 26, 2023
@matthiasschaub matthiasschaub changed the title feat(api): support content-type json for requests to /indicator feat(api): support json response for requests to /indicator endpoint via `accept' header Jun 26, 2023
@joker234 joker234 self-requested a review June 26, 2023 15:21
@matthiasschaub
feat(api): support json response for indicators
80488f3 
support json response for requests to /indicator endpoint via `accept'
header.

add custom HTTP Exception error to have a unified error response schema
add a wrapper for HTTP Exceptions.

add accept header to requests in tests
@matthiasschaub
tests(fixtures): remove properties from geojson fc
8c4b367
@matthiasschaub
tests(fixtures): create an alias for a fixture
8af6986
@matthiasschaub
tests(api): add/refactor tests
f8e17ad 
use pytest instead of unittest

introduce pytest parametrization
@matthiasschaub matthiasschaub merged commit 232b39d into main Jun 27, 2023
2 checks passed
@matthiasschaub matthiasschaub deleted the api-json-response branch June 27, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
api breaking This will break previous versions. Documentation and Changelog update compulsory enhancement New feature or request
Projects
None yet
Milestone
Release 0.15.0
Development

Successfully merging this pull request may close these issues.

API Response Schema
2 participants
@matthiasschaub @joker234