Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addressed #30 and #5 additionally deleted unneeded function #61

Merged
merged 7 commits into from
Jun 23, 2021

Conversation

ElJocho
Copy link
Contributor

@ElJocho ElJocho commented Jun 21, 2021

Description

Changes html parameters to id and report, reflects those changes on the main page and added a section in about which links the API and Github. Additionally changed the static zoom on click on a marker, which zoomed way too deep on countrys. Now it only zooms to the the bounds of a polygon.

Corresponding issue

Closes #30 and #5

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • I have updated the CHANGELOG.md

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
matthiasschaub
matthiasschaub previously approved these changes Jun 22, 2021
@matthiasschaub
Copy link
Collaborator

@ElJocho I did a short manual test of the website. Looks good to me. You can go ahead and merge it (maybe sqash and merge). Before you do consider if you want to take over my suggest changes to the changelog. You can simply hit the commit suggestion button if you want to do that.

Co-authored-by: Matthias Schaub <83658582+matthiasschaub@users.noreply.github.com>
ElJocho and others added 2 commits June 22, 2021 14:32
Co-authored-by: Matthias Schaub <83658582+matthiasschaub@users.noreply.github.com>
@ElJocho ElJocho merged commit afae451 into main Jun 23, 2021
@ElJocho ElJocho deleted the website_name_changes branch June 23, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website URL parameter names should be more precise
2 participants