Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api): use plural in JSON indicator response #627

Merged
merged 2 commits into from
Jun 29, 2023
Merged

chore(api): use plural in JSON indicator response #627

merged 2 commits into from
Jun 29, 2023

Conversation

joker234
Copy link
Member

@joker234 joker234 commented Jun 29, 2023 •
edited

Description

JSON response for /indicators/{key} now uses results instead of result on the top layer, since the value is an array with potentially multiple results.

Corresponding issue

None

New or changed dependencies

None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@joker234 joker234 added the api label Jun 29, 2023
@joker234 joker234 added this to the Release 0.15.0 milestone Jun 29, 2023
@joker234 joker234 merged commit c41086f into main Jun 29, 2023
2 checks passed
@joker234 joker234 deleted the result-results branch June 29, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasschaub matthiasschaub matthiasschaub approved these changes

Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
Release 0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joker234 @matthiasschaub