Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(db): refactor database setup #633

Merged
merged 9 commits into from
Jul 12, 2023
Merged

build(db): refactor database setup #633

merged 9 commits into from
Jul 12, 2023

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jul 4, 2023

Description

build(db): refactor database setup

  • remove database/development/
  • remove database/production/
  • add database/Dockerfile
    • download shdi and hexcells sql dumps during building of the
      database

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • [ ] I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md
  • Create idicies?
  • Wait till dataset and fid are removed
  • Update Jenkins (@joker234)

@matthiasschaub matthiasschaub marked this pull request as ready for review July 10, 2023 14:26
@matthiasschaub matthiasschaub force-pushed the refactor-database branch 2 times, most recently from 0ce2005 to d00aba1 Compare July 10, 2023 14:29
joker234
joker234 previously approved these changes Jul 11, 2023
matthiasschaub and others added 5 commits July 11, 2023 19:35
joker234
joker234 previously approved these changes Jul 11, 2023
@joker234 joker234 force-pushed the refactor-database branch 2 times, most recently from 983f3ef to 7351999 Compare July 12, 2023 08:07
joker234
joker234 previously approved these changes Jul 12, 2023
joker234
joker234 previously approved these changes Jul 12, 2023
@matthiasschaub matthiasschaub merged commit b889b74 into main Jul 12, 2023
2 checks passed
@matthiasschaub matthiasschaub deleted the refactor-database branch July 12, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants