Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api)!: remove dataset and fid parameter #634

Merged
merged 17 commits into from
Jul 10, 2023
Merged

refactor(api)!: remove dataset and fid parameter #634

merged 17 commits into from
Jul 10, 2023

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jul 4, 2023 •
edited

Description

Corresponding issue

Closes #

New or changed dependencies

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub changed the title Remove dataset fid refactor(api)!: remove dataset and fid parameter Jul 4, 2023
@matthiasschaub matthiasschaub added this to the Release 0.16.0 milestone Jul 5, 2023
@matthiasschaub matthiasschaub force-pushed the remove-dataset-fid branch 2 times, most recently from a5ffb80 to 24aed0e Compare July 6, 2023 13:16
@matthiasschaub matthiasschaub marked this pull request as ready for review July 6, 2023 13:17
joker234
joker234 reviewed Jul 10, 2023
View reviewed changes
workers/tests/integrationtests/test_oqt.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
matthiasschaub and others added 2 commits July 10, 2023 13:58
@matthiasschaub @joker234
Update workers/tests/integrationtests/test_oqt.py
567db3b 
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
@matthiasschaub
refactor(cli)!: remove cli
98cd3d6
@matthiasschaub matthiasschaub merged commit 0a02c68 into main Jul 10, 2023
2 checks passed
@matthiasschaub matthiasschaub deleted the remove-dataset-fid branch July 10, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthiasschaub @joker234