Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: remove include_svg, include_html and flatten parameter ([#644]) #644

Merged
merged 1 commit into from
Jul 12, 2023
Merged

api: remove include_svg, include_html and flatten parameter ([#644]) #644

merged 1 commit into from
Jul 12, 2023

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jul 12, 2023 •
edited

Corresponding issue

Closes #632
Closes #621
Closes #606

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md
  • Check if SVG jupyter notebook is linked in examples
  • Link documentation about using nested JSON objects as GeoJSON properties in QGIS

@matthiasschaub matthiasschaub changed the title refactor(api): remove include_x and flatten params api: remove include_svg, include_html and flatten parameter ([#644]) Jul 12, 2023
@matthiasschaub matthiasschaub marked this pull request as ready for review July 12, 2023 14:38
@matthiasschaub matthiasschaub merged commit 6c84125 into main Jul 12, 2023
2 checks passed
@matthiasschaub matthiasschaub deleted the api-remove-include-parameters branch July 12, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@matthiasschaub @joker234