Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapping-saturation: add estimted total to plot #658

Merged
merged 19 commits into from
Aug 22, 2023
Merged

mapping-saturation: add estimted total to plot #658

merged 19 commits into from
Aug 22, 2023

Conversation

Gigaszi
Copy link
Contributor

@Gigaszi Gigaszi commented Jul 20, 2023 •
edited by matthiasschaub

Description

Rename "fitted data" in legend to "modelled saturation curve" and plot now shows the estimated total data.

Corresponding issue

Closes #628
Closes #629
Closes #691
#688

New or changed dependencies

  • None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md
  • Improve legend placement
  • Add dashed line to legend

matthiasschaub
matthiasschaub reviewed Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@matthiasschaub matthiasschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool,looks good. I added some comments. Also could we add a test case where the asymptote lies way beyond the actual data?

CHANGELOG.md Outdated Show resolved Hide resolved
tests/integrationtests/indicators/test_mapping_saturation.py Outdated Show resolved Hide resolved
ohsome_quality_analyst/indicators/mapping_saturation/indicator.py Show resolved Hide resolved
ohsome_quality_analyst/indicators/mapping_saturation/indicator.py Outdated Show resolved Hide resolved
Gigaszi and others added 6 commits July 25, 2023 11:28
@Gigaszi @matthiasschaub
fix: test
878ffc4 
Co-authored-by: Matthias Schaub <83658582+matthiasschaub@users.noreply.github.com>
@Gigaszi @matthiasschaub
Update CHANGELOG.md
cd96e4c 
Co-authored-by: Matthias Schaub <83658582+matthiasschaub@users.noreply.github.com>
@Gigaszi @matthiasschaub
Update ohsome_quality_analyst/indicators/mapping_saturation/indicator.py
d850028 
Co-authored-by: Matthias Schaub <83658582+matthiasschaub@users.noreply.github.com>
@Gigaszi @matthiasschaub
Update ohsome_quality_analyst/indicators/mapping_saturation/indicator.py
2364eee 
Co-authored-by: Matthias Schaub <83658582+matthiasschaub@users.noreply.github.com>
@Gigaszi
chore: fix changelog
4b0f72a
@Gigaszi
Merge branch 'mapping_saturation_plot' of https://github.com/GIScienc…
e63a833 
…e/ohsome-quality-analyst into mapping_saturation_plot
matthiasschaub
matthiasschaub previously approved these changes Jul 26, 2023
View reviewed changes
@Gigaszi
Copy link
Contributor Author

Gigaszi commented Aug 21, 2023

Screenshot from 2023-08-21 16-46-35
Current state of the reworked plot. The plot is always at least 5% higher on the y-axis as the estimated total line. It shoudnt cross the legend in the upper left corner

@Gigaszi Gigaszi merged commit 5e974e4 into main Aug 22, 2023
2 checks passed
@Gigaszi Gigaszi deleted the mapping_saturation_plot branch August 22, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasschaub matthiasschaub matthiasschaub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Gigaszi @matthiasschaub