Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(indicator): overhaul currentness indicator #668

Merged
merged 25 commits into from
Aug 14, 2023
Merged

feat(indicator): overhaul currentness indicator #668

merged 25 commits into from
Aug 14, 2023

Conversation

Gigaszi
Copy link
Contributor

@Gigaszi Gigaszi commented Jul 25, 2023 •
edited by matthiasschaub

Description

Change intervall to monthly. Remove lightgray box indicating he median. Add secondary y-axis. Add legend with relative contributions per label.
Result: class_ and label are now calculated by the percentage in each bin of contributions.
There are now specific thresholds for the months in each bin.

Corresponding issue

Closes #662
Closes #661
Closes #665
Closes #666
Closes #664
Closes #663
Closes #623
Closes #514
Closes #74

New or changed dependencies

  • None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md
  • Fix tests (result description)
  • Have a look at TODO comments
  • Make sure it looks good on the dashboard

@matthiasschaub matthiasschaub changed the title improve currentness feat(indicator): overhaul currentness indicator Aug 9, 2023
@matthiasschaub matthiasschaub marked this pull request as ready for review August 14, 2023 10:32
@matthiasschaub matthiasschaub self-requested a review August 14, 2023 12:46
@matthiasschaub matthiasschaub merged commit 2ce5ec9 into main Aug 14, 2023
2 checks passed
@matthiasschaub matthiasschaub deleted the currentness_calculation branch August 14, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasschaub matthiasschaub Awaiting requested review from matthiasschaub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

currentness: include second y-axis with absolute number of contributions on the right side of the figure. currentness: remove gray box in favor of legend with total percentage of "green, yellow and red" bins currentness: since #622 information is missing from the result figure Currentness Indicator: Make it easy to understand by improving the as title, description and figure Currentness: Add a test case regarding more edits to features than there are features.
currentness: automatic tick placement on axis does not work well currentess: result description should only contain relevant label currentness: result class determination based on label share instead of mediam currentness: threshold customization on topic level
2 participants
@Gigaszi @matthiasschaub