Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ohsome API endpoint /contributions/latest/count for the Last Edit indicator #68

Merged
merged 7 commits into from
Jul 5, 2021
Merged

Use ohsome API endpoint /contributions/latest/count for the Last Edit indicator #68

merged 7 commits into from
Jul 5, 2021

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jun 28, 2021 •
edited

Corresponding issue

Closes #35

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@matthiasschaub matthiasschaub force-pushed the contributions-latest-count branch 2 times, most recently from 8ee83de to 9d3412e Compare June 28, 2021 11:47
joker234
joker234 reviewed Jul 5, 2021
View reviewed changes
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • General Question: why do we calculate shares in [0,100] and not [0,1] ranges?
  • get_latest_ohsome_timestamp() can have type hints as well

workers/ohsome_quality_analyst/indicators/last_edit/indicator.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/indicators/last_edit/indicator.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/indicators/last_edit/indicator.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/indicators/last_edit/indicator.py Outdated Show resolved Hide resolved
workers/ohsome_quality_analyst/indicators/last_edit/indicator.py Show resolved Hide resolved
workers/tests/integrationtests/test_indicator_last_edit.py Show resolved Hide resolved
@matthiasschaub matthiasschaub mentioned this pull request Jul 5, 2021
Closed
@matthiasschaub matthiasschaub force-pushed the contributions-latest-count branch 2 times, most recently from 63d1f53 to b85623f Compare July 5, 2021 11:40
@joker234 joker234 force-pushed the contributions-latest-count branch from 3827659 to 1e6f3f4 Compare July 5, 2021 13:28
@matthiasschaub matthiasschaub merged commit a44a3bd into main Jul 5, 2021
@matthiasschaub matthiasschaub deleted the contributions-latest-count branch July 5, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ohsome API endpoint /contributions/latest/count once it is available
2 participants
@matthiasschaub @joker234