crs check now acceps versions in crs-string #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| crs = bpolys.get("crs", None) | ||
| if crs is None: | ||
| pass | ||
| elif "urn:ogc:def:crs:OGC::CRS84" in crs["properties"]["name"]: | ||
| elif re.match( | ||
| r"urn:ogc:def:crs:OGC:\d+(\.\d+)*:CRS84", |
There was a problem hiding this comment.
Would fnmatch suffice? It would be easier to read: https://stackoverflow.com/questions/11427138/python-wildcard-search-in-string
|
Could you add a test case? |
matthiasschaub
force-pushed
the
crs-validation
branch
from
7918d3c
to
cac5426
Compare
|
Add test case for |
matthiasschaub
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding issue
Closes #716
Checklist
main(e.g. throughgit rebase main)Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using
~...~) and remove their checkboxes.