Implement as_feature functions for indicator/report
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2021
matthiasschaub
force-pushed
the
geo-interface-fix
branch
2 times, most recently
from
d78f515
to
a079f37
Compare
matthiasschaub
commented
Jul 9, 2021
joker234
reviewed
Jul 11, 2021
matthiasschaub
changed the title
as_feature functions for indicator/report
joker234
reviewed
Jul 12, 2021
joker234
reviewed
Jul 12, 2021
joker234
previously approved these changes
Jul 13, 2021
Fix udpate geojson function to not use vars() Update Changelog
`as_feature` is a function returning a GeoJSON object. Return report as Feature not as FeatureCollection. Add test for property keys of indicator Feature. Update Changelog. Clean up code. Fix issue where report attribute feature was None. This happend when input arguments were `dataset` and `feature_id`. Fixed by getting the feature from db and initialize report with feature and dataset+feature_id attributes. Create indicator will now prefer loading/saving from database when dataset+feature_id AND feature are given. Improve docs and comments. Fix wrong import statement. Add test case for running create_indicator with following arguments: feature, dataset and feature_id Improve docstrings
matthiasschaub
force-pushed
the
geo-interface-fix
branch
2 times, most recently
from
18e1fc0
to
124a109
Compare
joker234
reviewed
Jul 13, 2021
matthiasschaub
force-pushed
the
geo-interface-fix
branch
from
124a109
to
99b51f3
Compare
joker234
approved these changes
Jul 14, 2021
2 tasks
matthiasschaub
added a commit
that referenced
this pull request
Oct 5, 2021
This is obsolete since introduction of the property `data` for the indicator object in PR #86.
matthiasschaub
added a commit
that referenced
this pull request
Oct 5, 2021
This is obsolete since introduction of the property `data` for the indicator object in PR #86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement
as_featurefunction for indicator and report classes.Implement usage of new
as_featurefunction in the CLI.Corresponding issue
Closes #84 #67 #64 #12
See also issue #46 and rejected PR #66 for related discussions.
Checklist
main(e.g. throughgit rebase main)