Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make VCR mode configurable #95

Merged
merged 2 commits into from
Jul 19, 2021
Merged

make VCR mode configurable #95

merged 2 commits into from
Jul 19, 2021

Conversation

joker234
Copy link
Member

@joker234 joker234 commented Jul 16, 2021

Description

This change allows to configure if the tests never query the ohsome API but fail, or recreate all VCR cassettes, see https://vcrpy.readthedocs.io/en/latest/usage.html#record-modesv

Corresponding issue

None

New or changed dependencies

None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@joker234 joker234 added CI Related to continuous integration (unit tests, build settings, etc.) tests Issues with tests labels Jul 16, 2021
@joker234 joker234 added this to the Release 0.5.0 milestone Jul 16, 2021
@joker234 joker234 changed the title 🚧 make VCR mode configurable (fails on purpose) make VCR mode configurable Jul 16, 2021
@joker234 joker234 force-pushed the vcr-mode-configurable branch 2 times, most recently from 05dd8cc to 92d12e7 Compare July 19, 2021 08:03
matthiasschaub
matthiasschaub previously approved these changes Jul 19, 2021
@joker234 joker234 merged commit e9c990b into main Jul 19, 2021
@joker234 joker234 deleted the vcr-mode-configurable branch July 19, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Related to continuous integration (unit tests, build settings, etc.) tests Issues with tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants