Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return type from bool to None for indicator #96

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jul 19, 2021

Description

Change return type from bool to None for indicator for functions: preprocess, calculate, create_figure

Corresponding issue

Closes #

New or changed dependencies

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

@matthiasschaub matthiasschaub force-pushed the return-type-of-abstract-methods-base-class-2 branch from 938ebe4 to 5676f78 Compare July 19, 2021 13:52
@matthiasschaub matthiasschaub added the waiting for review This pull request urgently needs a code review label Jul 19, 2021
@matthiasschaub matthiasschaub removed the waiting for review This pull request urgently needs a code review label Jul 28, 2021
Gigaszi
Gigaszi previously approved these changes Jul 28, 2021
Copy link
Contributor

@Gigaszi Gigaszi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everthing looks fine

functions: preprocess, calculate, create_figure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants