feat(indicators): add inverse parameter to coverage function and add inversed eubucco coverage #762
+86
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasschaub
previously approved these changes
Dec 18, 2023
| @@ -39,8 +39,8 @@ def __init__( | |||
| self.above_one_th = 1.30 | |||
|
|
|||
| @classmethod | |||
| async def coverage(cls) -> Polygon | MultiPolygon: | |||
| result = await db_client.get_eubucco_coverage() | |||
| async def coverage(cls, inverse=True) -> Polygon | MultiPolygon: | |||
There was a problem hiding this comment.
Suggested change
| async def coverage(cls, inverse=True) -> Polygon | MultiPolygon: | |
| async def coverage(cls, inverse=False) -> Polygon | MultiPolygon: |
| @@ -43,9 +43,18 @@ def test_get_indicator_definitions_with_project(): | |||
| assert indicator.projects == ["core"] | |||
|
|
|||
|
|
|||
| def test_get_coverage(mock_select_eubucco_coverage): | |||
| coverage = asyncio.run(definitions.get_coverage("building-comparison")) | |||
| def test_get_coverage(): | |||
matthiasschaub
previously approved these changes
Dec 18, 2023
matthiasschaub
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corresponding issue
Closes #749
New or changed dependencies
Checklist
main(e.g. throughgit rebase main)