Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share to shortened URL produces unusable result #245

Closed
ManDay opened this issue Nov 24, 2021 · 5 comments
Closed

Share to shortened URL produces unusable result #245

ManDay opened this issue Nov 24, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@ManDay
Copy link

ManDay commented Nov 24, 2021

Sharing a track to a shortened URL produces a different result than the long URL. The former, in fact, does not work.

Example:

The long link copied from the "Share" box:

https://maps.openrouteservice.org/#/directions/%D0%A2%D0%BE%D0%B4%D0%BE%D1%80%D0%B8%D0%BD%20%D0%92%D1%80%D1%8A%D1%85,Bansko,BL,Bulgaria/%D0%9C%D0%B0%D0%BD%D0%B0%D1%81%D1%82%D0%B8%D1%80%D1%81%D0%BA%D0%B0%20%D0%BA%D0%BD%D0%B8%D0%B6%D0%B0%D1%80%D0%BD%D0%B8%D1%86%D0%B0,KY,Bulgaria/data/55,130,32,198,15,97,4,224,38,9,96,59,2,24,5,192,166,6,113,0,184,64,38,1,152,3,160,5,128,14,11,240,17,144,234,4,224,21,156,128,24,95,32,26,83,174,60,194,152,14,192,49,128,54,124,66,42,16,13,196,88,161,126,3,74,55,175,79,185,124,140,7,226,239,152,173,66,164,199,145,18,218,163,26,132,68,128,226,2,0,7,84,240,34,38,195,148,0,47,40,1,109,115,85,35,110,218,2,0,12,222,0,6,221,23,4,24,42,21,0,22,128,2,222,0,26,201,0,28,218,196,16,61,24,61,26,29,17,12,18,47,31,50,11,203,192,182,29,22,4,0,23,214,168,0,0

The shortened link https://bit.ly/3HTbZcL otoh expands to a non-working URL:

https://maps.openrouteservice.org/#/directions/%D0%BE%D1%82%D0%B5%D1%86%20%D0%A1%D1%82%D0%B5%D1%84%D0%B0%D0%BD%20%D0%9A%D0%B0%D0%BC%D0%B1%D0%B5%D1%80%D0%BE%D0%B2,Bansko,BL,Bulgaria/TT12/2,BL,Bulgaria/Blagoevgrad,Bulgaria/Iliyna%20Reka,KY,Bulgaria/data/55,130,32,198,15,97,4,224,38,9,96,59,2,24,5,192,166,6,113,0,184,64,38,1,152,3,160,5,128,14,124,7,96,17,156,210,3,98,182,253,72,1,129,128,105,73,184,250,28,36,84,171,34,1,57,240,48,13,196,76,135,54,249,201,85,37,64,43,10,242,43,69,86,235,220,126,9,162,106,19,110,92,177,169,51,132,48,92,180,91,54,132,236,50,227,216,168,149,171,86,18,58,78,213,66,210,36,222,26,172,132,12,28,42,76,194,220,248,196,52,62,108,90,250,204,14,132,42,32,156,32,16,0,14,168,240,16,136,216,56,160,0,94,80,0,182,184,52,92,32,217,208,16,0,102,240,0,54,232,184,32,13,80,168,0,180,0,22,240,0,214,72,0,230,25,181,208,232,13,232,19,136,96,109,120,152,189,48,24,152,168,32,0,190,235,64,0,0

@ManDay
Copy link
Author

ManDay commented Nov 24, 2021

In fact, neither link appears to contain the VIA points of the original track (separate issue?).

For reference:
20211124_16h03m06s_grim

@rabidllama rabidllama transferred this issue from GIScience/openrouteservice Nov 25, 2021
@rabidllama
Copy link
Contributor

Moved this over to the map client repo as it is an issue with the client and not the routing engine

@amoncaldas
Copy link
Contributor

amoncaldas commented Nov 25, 2021

Dear @ManDay

I just tested it and I could not reproduce the issue.

The steps I followed:

  • clicked on the first link you provided "The long link copied from the "Share" box:"
  • the route was rendered on the map
  • clicked on share and then short url (the shortened url generated was https://bit.ly/3CMdXbd and not https://bit.ly/3HTbZcL)
  • copied the shortened url, opened a new tab and loaded the app using it, resulting in the same route visualization

Please note that bit.ly does not create a new shortened url for the same raw url. So, I can guess that the long url you used to generate a short one was not the one you pointed on the issue.

Let me know if you have new evidences or steps to reproduce it.

Amon

@ManDay
Copy link
Author

ManDay commented Nov 25, 2021

True. The problem is more intricate than I first thought. To reproduce:

  • Open the first (long) link
  • Add a VIA point by dragging some piece of the track elsewhere
  • Open the Share long link → VIA point is missing
  • Open the Share short link → VIA point is there

So in summary, my initial problem and what I reported above appears to be one specific symptom of a problem where versions of the Share link are ill-sync'ed with the current track.

Does that make sense to you?

NB: It's really finicky in how it can be reproduced. For example if I drag the VIA ("2") marker multiple times before going to Share, the VIA point does appear in the long URL, too.

@amoncaldas amoncaldas added the bug Something isn't working label Nov 25, 2021
@ManDay
Copy link
Author

ManDay commented Nov 28, 2021

@amoncaldas There is something not right with the URL shortening beyond the maps client. I tried this multiple times and bit.ly, the service which you use, botchers the link somehow when I paste it manually on their website.

This URL which works become this broken URL after bit.ly expanded it. Maybe it's related to the cryllic chars, but it certainly is broken on the bit.ly site. Another service I tried shorturl.at works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants