speedup building of geometries from osm entities #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relations with many (small) inner rings used to take a long time to assemble, because each of the "within" operation in a loop. by using a prepared geometry, this is substantially faster
tyrasd
changed the title
tyrasd
added
the
performance
|
|
applies the idea from #66 to the cellIterator functions: some objects might have large OSH bboxes, but small geometries. Then it is not always necessary to calculate actual intersections (which are potentially slow).
tyrasd
force-pushed
the
performance-speedup-complex-multipolygons
branch
from
850b2a0
to
84a1393
Compare
rtroilo
approved these changes
Mar 8, 2019
|
can confirm speed improvement of 3x faster on ignite (tested locally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes two improvements for building geometries:
Relations with many (small) inner rings used to take a long time to assemble, because each of the expensive
withinoperation in a loop. By using a prepared geometry, this is substantially faster. Eespecially for particularly complex example like relation/571669 this makes a large difference: processing times went down from several minutes to a few seconds.This applies the idea from improved splitting of "large" snapshot and contribution objects #66 to the cellIterator functions: Some objects might have a large OSH bbox, but small (snapshot or contribution) geometries. Then it is not always necessary to calculate actual intersections, which are potentially slow computations.